Game hangs after killing boss, fixed

DrLex · 06-24-2003, 09:46 AM

There appears to be a missing line of code in GameLoop() in rt_main.c around line 1300, which causes an infinite loop when waiting for a keystroke while showing the "R.I.P." screen:

<blockquote>code:<hr /><pre style="font-size:x-small; font-family: monospace;">WaitKeyUp();
LastScan = 0;
while (!LastScan)
;
LastScan=0;
}[/code]</blockquote>No idea why this line of code went fishing, but the fix is simple:
<blockquote>code:<hr /><pre style="font-size:x-small; font-family: monospace;">WaitKeyUp();
IN_ClearKeysDown(); // probably not needed but can't hurt
LastScan = 0;
while (!LastScan)
IN_UpdateKeyboard(); // fixed!
LastScan=0;}[/code]</blockquote>It's about time I pack together all bug fixes I found until now, and send them to the icculus guys so they can add them to the CVS.

theoddone33 · 06-25-2003, 08:06 PM

DrLex:

I've put three of your fixes into icculus.org CVS. Thanks for catching these mistakes!

If there were more than three, please let me know. I only found three posts of yours with fixes in them.

DrLex · 06-25-2003, 08:18 PM

It were only these three fixes indeed:
-audio setup endianness in fx_man.c
-broken glass endianness in rt_door.c
-missing keyboard input line in rt_main.c

I'll see if I can find some more [img]images/icons/smile.gif[/img]

Joe Siegler · 07-02-2003, 04:05 PM

Well, ROTT was originally designed for the bosses only to be used on specific level numbers. I'm not a programmer, so I can't tell you why we did that, but I know we were told we couldn't use NME or Krist or any other boss outside the level they were alotted for boss levels or the game would crash.

theoddone33 · 07-02-2003, 08:52 PM

This one was 100% our fault. Rott used a standard (for the time) ISR to update keyboard info. Can't do this on modern OS's so we had to add a function to poll it. Once you throw that in, you have to play through the game to find places where the game hangs looking for keyboard input, then add the polling function into that particular spot. We just missed this one because we all sucked too much at the game.

07-02-2003, 04:05 PM	#4
Joe Siegler 3D Realms Staff	Re: Game hangs after killing boss, fixed Well, ROTT was originally designed for the bosses only to be used on specific level numbers. I'm not a programmer, so I can't tell you why we did that, but I know we were told we couldn't use NME or Krist or any other boss outside the level they were alotted for boss levels or the game would crash. __________________ Apogee / 3D Realms Employee: Dec 14, 1992 - May 22, 2009, Oct 23, 2014 - current "Lifting up the Cross to the waiting lost" - Petra \| John 3:16

06-24-2003, 09:46 AM	#1
DrLex	Game hangs after killing boss, fixed There appears to be a missing line of code in GameLoop() in rt_main.c around line 1300, which causes an infinite loop when waiting for a keystroke while showing the "R.I.P." screen: </font><blockquote><font size="1" face="Verdana, Arial">code:</font><hr /><pre style="font-size:x-small; font-family: monospace;">WaitKeyUp(); LastScan = 0; while (!LastScan) ; LastScan=0; }[/code]</blockquote><font size="2" face="Verdana, Arial">No idea why this line of code went fishing, but the fix is simple: </font><blockquote><font size="1" face="Verdana, Arial">code:</font><hr /><pre style="font-size:x-small; font-family: monospace;">WaitKeyUp(); IN_ClearKeysDown(); // probably not needed but can't hurt LastScan = 0; while (!LastScan) IN_UpdateKeyboard(); // fixed! LastScan=0;}[/code]</blockquote><font size="2" face="Verdana, Arial">It's about time I pack together all bug fixes I found until now, and send them to the icculus guys so they can add them to the CVS.

06-25-2003, 08:06 PM	#2
theoddone33	Re: Game hangs after killing boss, fixed DrLex: I've put three of your fixes into icculus.org CVS. Thanks for catching these mistakes! If there were more than three, please let me know. I only found three posts of yours with fixes in them.

06-25-2003, 08:18 PM	#3
DrLex	Re: Game hangs after killing boss, fixed It were only these three fixes indeed: -audio setup endianness in fx_man.c -broken glass endianness in rt_door.c -missing keyboard input line in rt_main.c I'll see if I can find some more [img]images/icons/smile.gif[/img]

07-02-2003, 08:52 PM	#5
theoddone33	Re: Game hangs after killing boss, fixed This one was 100% our fault. Rott used a standard (for the time) ISR to update keyboard info. Can't do this on modern OS's so we had to add a function to poll it. Once you throw that in, you have to play through the game to find places where the game hangs looking for keyboard input, then add the polling function into that particular spot. We just missed this one because we all sucked too much at the game.